Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update naming conventions in EDC classes #102

Conversation

eschrewe
Copy link
Contributor

@eschrewe eschrewe commented Dec 4, 2023

Description

Several renamings as requested in issue #101 , solving that issue.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smaller changes are needed. Please also rename the Issue to something more meaningful like "refactor: update naming conventions in EDC classes"

@eschrewe eschrewe changed the title refactor: initial commit refactor: update naming conventions in EDC classes Dec 5, 2023
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor: Remove Dsp naming convention from EdcAdapterService and EDCRrequestBodyBuilder
2 participants