Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/helm subcharts #111

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Refactor/helm subcharts #111

merged 2 commits into from
Dec 12, 2023

Conversation

PaMarzec
Copy link
Contributor

@PaMarzec PaMarzec commented Dec 6, 2023 •
edited
Loading

Description

Resolves Issue #110

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 6, 2023
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KICS found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 12, 2023
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KICS found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@tom-rm-meyer-ISST tom-rm-meyer-ISST mentioned this pull request Dec 12, 2023
Merged
2 tasks
tom-rm-meyer-ISST
tom-rm-meyer-ISST approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit bce39aa into eclipse-tractusx:main Dec 12, 2023
12 checks passed
@tom-rm-meyer-ISST tom-rm-meyer-ISST deleted the refactor/helm-subcharts branch December 12, 2023 11:13
@tom-rm-meyer-ISST tom-rm-meyer-ISST linked an issue Dec 18, 2023 that may be closed by this pull request
refactor: deletion of subchart folder in helm #110
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-rm-meyer-ISST tom-rm-meyer-ISST tom-rm-meyer-ISST approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor: deletion of subchart folder in helm
2 participants
@PaMarzec @tom-rm-meyer-ISST