Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: soften mad related constraints #146

Merged
merged 11 commits into from
Dec 21, 2023

Conversation

tom-rm-meyer-ISST
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST commented Dec 21, 2023

Description

During preparation of the integration test, the postman collection failed for two constraints:

  • the following edcUrl in partner was not applicable: "https://isst-edc.int.demo.catena-x.net" (realized that I should configure it with /api/v1/dsp but nethertheless this might cause issues with other partners' ingress configuration)
  • the names were not able to contain "." which would prevent e.g. the name "Supplier Inc."
  • there was a transient issue that the material stock didn't search for the material during creation to ensure integrity

Additionally I created Test Classes for the patterns in MAD.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

Copy link
Member

@mhellmeier mhellmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the DEPENDENCIES_FRONTEND file which seems to be outdated based on the pipeline.

Copy link
Member

@mhellmeier mhellmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependencies problems are fixed due to a problem with the Dash tool.

@mhellmeier mhellmeier merged commit e5c7d45 into eclipse-tractusx:main Dec 21, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants