Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add order position reference to stockview #155

Merged
merged 12 commits into from
Jan 4, 2024
Merged

Feat: add order position reference to stockview #155

merged 12 commits into from
Jan 4, 2024

Conversation

tom-rm-meyer-ISST
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST commented Jan 4, 2024 •
edited
Loading

Description

This PR prepares the StockView to process Order Position References. It adds three new fields with no further handling:

  • customer order number
  • customer order position number
  • supplier order number

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@tom-rm-meyer-ISST tom-rm-meyer-ISST marked this pull request as ready for review January 4, 2024 10:06
mhellmeier
mhellmeier requested changes Jan 4, 2024
View reviewed changes
Copy link
Member

@mhellmeier mhellmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest carefully reviewing all files for breaking HTML tags. I just showed two examples.

frontend/src/views/stock/StockTableSFC.vue Outdated Show resolved Hide resolved
frontend/src/views/stock/StockTableSFC.vue Outdated Show resolved Hide resolved
@mhellmeier mhellmeier merged commit 8c1ded5 into eclipse-tractusx:main Jan 4, 2024
12 checks passed
@tom-rm-meyer-ISST tom-rm-meyer-ISST deleted the feat/stockview-add-orderPositionReference branch January 4, 2024 11:49
@tom-rm-meyer-ISST tom-rm-meyer-ISST linked an issue Jan 22, 2024 that may be closed by this pull request
Feat: add Order Position Reference to Frontend #148
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhellmeier mhellmeier mhellmeier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: add Order Position Reference to Frontend
2 participants
@tom-rm-meyer-ISST @mhellmeier