-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added postman collection for integration test #160
feat: added postman collection for integration test #160
Conversation
…lier - added documentation of test data
…local/postman/README.md
@eschrewe please review. I changed the following:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done, I like it very much :)
My remarks are concerning only some minor issues
…tatus request check
backend/src/main/java/org/eclipse/tractusx/puris/backend/DataInjectionCommandLineRunner.java
Fixed
Show resolved
Hide resolved
backend/src/main/java/org/eclipse/tractusx/puris/backend/DataInjectionCommandLineRunner.java
Fixed
Show resolved
Hide resolved
backend/src/main/java/org/eclipse/tractusx/puris/backend/DataInjectionCommandLineRunner.java
Fixed
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, great effort!
Only a small handful of things I noticed, see the new comments
backend/src/main/java/org/eclipse/tractusx/puris/backend/DataInjectionCommandLineRunner.java
Fixed
Show resolved
Hide resolved
backend/src/main/java/org/eclipse/tractusx/puris/backend/DataInjectionCommandLineRunner.java
Fixed
Show resolved
Hide resolved
# Conflicts: # frontend/src/views/StockView.vue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay for me. Even if there are >1000 LOC, the majority of lines are based on a JSON export of the Postman collection. Therefore, merging is fine for me.
Description
Added Postman collection to prepare and run integration tests based on non-demo setup puris instances.
It creates a setup of a partner and customer that refer to the same material from the other perspective:
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: