Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added postman collection for integration test #160

Merged
merged 14 commits into from
Jan 22, 2024

Conversation

tom-rm-meyer-ISST
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST commented Jan 5, 2024

Description

Added Postman collection to prepare and run integration tests based on non-demo setup puris instances.

It creates a setup of a partner and customer that refer to the same material from the other perspective:

  • The customer has the material and a material stock
  • The supplier has the product and a product stock
  • Both partners know each other and each other's EDC
  • The setup is ready to trigger the update from customer to supplier

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@tom-rm-meyer-ISST tom-rm-meyer-ISST linked an issue Jan 5, 2024 that may be closed by this pull request
@tom-rm-meyer-ISST tom-rm-meyer-ISST marked this pull request as ready for review January 5, 2024 13:43
@tom-rm-meyer-ISST
Copy link
Contributor Author

@eschrewe please review. I changed the following:

  • added a listing of test data in local/postman/README.md.
  • streamlined variables to be consistent to supplier / customer (no mixture with consumer / provider)
  • updated application properties to names used in README.md -> will need further update in others

Copy link
Contributor

@eschrewe eschrewe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, I like it very much :)
My remarks are concerning only some minor issues

local/postman/Local Dev.postman_environment.json Outdated Show resolved Hide resolved
backend/src/main/resources/application.properties Outdated Show resolved Hide resolved
Copy link
Contributor

@eschrewe eschrewe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, great effort!
Only a small handful of things I noticed, see the new comments

Copy link
Member

@mhellmeier mhellmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay for me. Even if there are >1000 LOC, the majority of lines are based on a JSON export of the Postman collection. Therefore, merging is fine for me.

@mhellmeier mhellmeier merged commit 4ef23fd into eclipse-tractusx:main Jan 22, 2024
12 checks passed
@tom-rm-meyer-ISST tom-rm-meyer-ISST deleted the feat/postman branch January 22, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: add a postman collection for integration test
3 participants