Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/Register DTR at EDC #247

Merged
merged 5 commits into from
Feb 12, 2024
Merged

Feat/Register DTR at EDC #247

merged 5 commits into from
Feb 12, 2024

Conversation

eschrewe
Copy link
Contributor

@eschrewe eschrewe commented Feb 8, 2024

  • added DTR containers to local setup for customer and supplier

  • added registration procedure for DTR asset at backend startup

  • added contractdefinition registration per partner for DTR asset, solving Register DTR at EDC #182

  • some minor cleanup in EdcAdapterService

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.

  • Copyright and license header are present on all affected files

github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 8, 2024
View reviewed changes
local/docker-compose.yaml Fixed Show fixed Hide fixed
local/docker-compose.yaml Fixed Show fixed Hide fixed
local/docker-compose.yaml Fixed Show fixed Hide fixed
local/docker-compose.yaml Fixed Show fixed Hide fixed
local/docker-compose.yaml Fixed Show fixed Hide fixed
local/docker-compose.yaml Fixed Show fixed Hide fixed
local/docker-compose.yaml Fixed Show fixed Hide fixed
local/docker-compose.yaml Fixed Show fixed Hide fixed
local/docker-compose.yaml Fixed Show fixed Hide fixed
local/docker-compose.yaml Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 8, 2024
View reviewed changes
local/docker-compose.yaml
@@ -177,6 +198,25 @@
extra_hosts:
- "host.docker.internal:host-gateway" # Adjusts container's host file to allow for communication with docker-host machine

dtr-supplier:

Check warning

Code scanning / KICS

Healthcheck Not Set Warning

Healthcheck is not defined.
local/docker-compose.yaml
@@ -68,6 +68,25 @@
extra_hosts:
- "host.docker.internal:host-gateway" # Adjusts container's host file to allow for communication with docker-host machine

dtr-customer:

Check warning

Code scanning / KICS

Healthcheck Not Set Warning

Healthcheck is not defined.
local/docker-compose.yaml
@@ -177,6 +198,25 @@
extra_hosts:
- "host.docker.internal:host-gateway" # Adjusts container's host file to allow for communication with docker-host machine

dtr-supplier:

Check warning

Code scanning / KICS

Host Namespace is Shared Warning

There is no pid mode declared
local/docker-compose.yaml
@@ -68,6 +68,25 @@
extra_hosts:
- "host.docker.internal:host-gateway" # Adjusts container's host file to allow for communication with docker-host machine

dtr-customer:

Check warning

Code scanning / KICS

Host Namespace is Shared Warning

There is no pid mode declared
local/docker-compose.yaml
@@ -177,6 +198,25 @@
extra_hosts:
- "host.docker.internal:host-gateway" # Adjusts container's host file to allow for communication with docker-host machine

dtr-supplier:

Check warning

Code scanning / KICS

Memory Not Limited Warning

'deploy' is not defined
local/docker-compose.yaml
@@ -68,6 +68,25 @@
extra_hosts:
- "host.docker.internal:host-gateway" # Adjusts container's host file to allow for communication with docker-host machine

dtr-customer:

Check warning

Code scanning / KICS

Security Opt Not Set Warning

Docker compose file does not have 'security_opt' attribute
local/docker-compose.yaml
@@ -177,6 +198,25 @@
extra_hosts:
- "host.docker.internal:host-gateway" # Adjusts container's host file to allow for communication with docker-host machine

dtr-supplier:

Check notice

Code scanning / KICS

Container Capabilities Unrestricted Note

Docker compose file doesn't have 'cap_drop' attribute. Make sure your container only has necessary capabilities.
local/docker-compose.yaml
@@ -68,6 +68,25 @@
extra_hosts:
- "host.docker.internal:host-gateway" # Adjusts container's host file to allow for communication with docker-host machine

dtr-customer:

Check notice

Code scanning / KICS

Container Capabilities Unrestricted Note

Docker compose file doesn't have 'cap_drop' attribute. Make sure your container only has necessary capabilities.
local/docker-compose.yaml
@@ -68,6 +68,25 @@
extra_hosts:
- "host.docker.internal:host-gateway" # Adjusts container's host file to allow for communication with docker-host machine

dtr-customer:

Check notice

Code scanning / KICS

Cpus Not Limited Note

'deploy' is not defined
local/docker-compose.yaml
@@ -177,6 +198,25 @@
extra_hosts:
- "host.docker.internal:host-gateway" # Adjusts container's host file to allow for communication with docker-host machine

dtr-supplier:

Check notice

Code scanning / KICS

Cpus Not Limited Note

'deploy' is not defined
f-zimmer
f-zimmer suggested changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@f-zimmer f-zimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides some minor change requests, great job!

...main/java/org/eclipse/tractusx/puris/backend/common/edc/logic/service/EdcAdapterService.java Outdated Show resolved Hide resolved
...main/java/org/eclipse/tractusx/puris/backend/common/edc/logic/service/EdcAdapterService.java Outdated Show resolved Hide resolved
...main/java/org/eclipse/tractusx/puris/backend/common/edc/logic/service/EdcAdapterService.java Show resolved Hide resolved
f-zimmer
f-zimmer approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@f-zimmer f-zimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhellmeier
mhellmeier approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@mhellmeier mhellmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay for me, since the security findings aren't so relevant for a local setup that shouldn't be used in a productive environment.

@mhellmeier mhellmeier merged commit 9fca403 into eclipse-tractusx:main Feb 12, 2024
12 checks passed
@tom-rm-meyer-ISST tom-rm-meyer-ISST linked an issue Mar 19, 2024 that may be closed by this pull request
Register DTR at EDC #182
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-zimmer f-zimmer f-zimmer approved these changes

@mhellmeier mhellmeier mhellmeier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Register DTR at EDC
3 participants
@eschrewe @mhellmeier @f-zimmer