Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update security-assessment.md #250

Merged
merged 2 commits into from
Feb 17, 2024

Conversation

szymonkowalczykzf
Copy link
Contributor

Added Mermaid Diagram.
Additionally removed Vulnerabilities number 5&7 (Rate Limitting & encryption of data at rest) due to the fact that they are still open and I believe we had an agreement to upload here only the addressed vulnerabilities.

I have already accepted the threat modeling requirement for the Quality Gate 24 March 2024.

Please review and approve.

Description

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

Added Mermaid Diagram.
Additionally removed Vulnerabilities number 5&7 (Rate Limitting & encryption of data at rest) due to the fact that they are still open and I believe we had an agreement to upload here only the addressed vulnerabilities.

I have already accepted the threat modeling requirement for the Quality Gate 24 March 2024.

Please review and approve.
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add one comma for readability. Rest ist top! Wasn't aware of the native integration of mermaid in GIthub! :)

docs/security-assessment.md Outdated Show resolved Hide resolved
Readability changes requested by Tom
@szymonkowalczykzf
Copy link
Contributor Author

@tom-rm-meyer-ISST Change implemented, did not catch up this one earlier, thanks.

Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for providing!

@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit a6ca42f into eclipse-tractusx:main Feb 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants