Chore/add javadocs #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tom-rm-meyer-ISST
requested changes
Aug 29, 2023
backend/src/main/java/org/eclipse/tractusx/puris/backend/common/edc/logic/dto/EDR_Dto.java
Outdated
Show resolved
Hide resolved
...rg/eclipse/tractusx/puris/backend/common/edc/logic/service/EndpointDataReferenceService.java
Show resolved
Hide resolved
backend/src/main/java/org/eclipse/tractusx/puris/backend/masterdata/domain/model/Material.java
Show resolved
Hide resolved
backend/src/main/java/org/eclipse/tractusx/puris/backend/masterdata/domain/model/Partner.java
Outdated
Show resolved
Hide resolved
...rg/eclipse/tractusx/puris/backend/stock/logic/service/ProductStockRequestApiServiceImpl.java
Show resolved
Hide resolved
|
Quality check still fails because we need to incorporate this issue: eclipse-tractusx/sig-infra#230 |
mhellmeier
force-pushed
the
chore/add-javadocs
branch
from
a727780
to
903afbd
Compare
|
@mhellmeier last comment is postponed. Quality Check still fails, but has been reported. Fine from my side. |
tom-rm-meyer-ISST
merged commit d2f4af7
into
eclipse-tractusx:main
8 of 9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended Javadocs in the backend.
Improved Swagger-UI documentation
Included some minor fixes in order to improve the status code responses in request and response endpoints. Also renamed the objects of the DT_RequestStateEnum class to better match the wording of the PURIS api.