Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/include measurementunits in stocks #32

Merged
merged 5 commits into from
Sep 18, 2023
Merged

Feat/include measurementunits in stocks #32

merged 5 commits into from
Sep 18, 2023

Conversation

eschrewe
Copy link
Contributor

@eschrewe eschrewe commented Sep 5, 2023

Description

  • included MeasurementUnits in Stock and its sub classes.
  • productstocksammdto now using java.util.date instead of xmlgregorian

Pre-review checks

@tom-rm-meyer-ISST
Copy link
Contributor

@eschrewe please rebase the branch and tag me afterwards for review :)

@eschrewe eschrewe force-pushed the feat/include_measurementunits_in_stocks branch from 5c89d0d to 6af0a91 Compare September 18, 2023 06:28
@eschrewe
Copy link
Contributor Author

@eschrewe please rebase the branch and tag me afterwards for review :)

Done!

tom-rm-meyer-ISST
tom-rm-meyer-ISST reviewed Sep 18, 2023
View reviewed changes
backend/src/main/resources/application-customer.properties
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure to not always include the application.proerties for local ports.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, will remember that next time...

tom-rm-meyer-ISST
tom-rm-meyer-ISST approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please consider comment in future. Quality Check is related to helm that has not been changed. Will be handled in issues #34 and #35

@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit dcfccba into eclipse-tractusx:main Sep 18, 2023
9 of 10 checks passed
@tom-rm-meyer-ISST tom-rm-meyer-ISST deleted the feat/include_measurementunits_in_stocks branch September 18, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-rm-meyer-ISST tom-rm-meyer-ISST tom-rm-meyer-ISST approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eschrewe @tom-rm-meyer-ISST