Draft: Added membership credential as contract policy #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tom-rm-meyer-ISST
requested changes
Apr 10, 2024
There was a problem hiding this comment.
Works pretty good! I found a small bug in the frontend, I also didn't think about earlier. Currently the condition in the Catalog View only thinks about one policy and not about two. Thus, it would be great if you could update that, too. Beside that I also noticed the asset type is currently linked to asset:prop:type but should be linked to
"dct:type":{
"@id": "https://w3id.org/catenax/taxonomy#Submodel"
}
…credential mandatory. Adjusted config and deployment files and docs accordingly. Enhanced frontend to display multiple permission conditions.
…ther than contract policy. Incremented chart.yml semver.
…small label typo of prohibition and obligation.
…l code mispellings in EdcAdapterService.
f-zimmer
force-pushed
the
feat/187-membership-credential
branch
from
a79cfe0
to
1ad8c04
Compare
|
@f-zimmer please solve merge conflicts and reassign review |
…redential # Conflicts: # backend/src/main/java/org/eclipse/tractusx/puris/backend/common/edc/logic/service/EdcAdapterService.java
tom-rm-meyer-ISST
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: