Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implemented delivery information in the frontend #362

Conversation

ReneSchroederLJ
Copy link
Contributor

@ReneSchroederLJ ReneSchroederLJ commented May 13, 2024

Description

  • implemented Delivery Information in the frontend
  • updated environments and helm chart
  • implemented refresh button for requesting data for all submodels

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@ReneSchroederLJ ReneSchroederLJ marked this pull request as ready for review May 13, 2024 06:19
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code overall looks great. Also display logic is well done.

Local deployment does not work. Updated docker-compose.yaml and config but for some reason getting the following logs.
image

Tested with npm. Please check findings and fix local deployment.

# -- The endpoint for the production range of the production submodel
endpointProductionRange: production/range
# -- The endpoint for the delivery submodel
endpointDelivery: delivery
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run helm-docs to update the readme of the chart

frontend/.env Show resolved Hide resolved
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fixes, just one useability question + also copy DEPENDENCIES_FRONTEND to frontend/DEPENDENCIES (needed for distribution of docker image).

Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for iterating over this with me.

Sidenote: compared initial commit with state at main at that point using git diff --stat -w a81a3684d5228b4d5c8af52cd72b56f76aa52bbe d33e1df25fa3ffa731d0e2a11f629016b48be20c which was less than 1 kloc (exluding license headers, any kind of config). Please remain patient and if possible, please try to remain a little more below, if possible :) But here I don't see any IP threats!

@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit ffd76f0 into eclipse-tractusx:main May 16, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants