-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implemented delivery information in the frontend #362
feat: implemented delivery information in the frontend #362
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# -- The endpoint for the production range of the production submodel | ||
endpointProductionRange: production/range | ||
# -- The endpoint for the delivery submodel | ||
endpointDelivery: delivery |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run helm-docs to update the readme of the chart
frontend/src/features/dashboard/components/DeliveryInformationModal.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great fixes, just one useability question + also copy DEPENDENCIES_FRONTEND to frontend/DEPENDENCIES (needed for distribution of docker image).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for iterating over this with me.
Sidenote: compared initial commit with state at main at that point using git diff --stat -w a81a3684d5228b4d5c8af52cd72b56f76aa52bbe d33e1df25fa3ffa731d0e2a11f629016b48be20c
which was less than 1 kloc (exluding license headers, any kind of config). Please remain patient and if possible, please try to remain a little more below, if possible :) But here I don't see any IP threats!
Description
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: