Feat/api for entity management #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tom-rm-meyer-ISST
requested changes
Sep 26, 2023
backend/src/main/java/org/eclipse/tractusx/puris/backend/controller/MaterialController.java
Outdated
Show resolved
Hide resolved
...n/java/org/eclipse/tractusx/puris/backend/controller/MaterialPartnerRelationsController.java
Outdated
Show resolved
Hide resolved
...n/java/org/eclipse/tractusx/puris/backend/controller/MaterialPartnerRelationsController.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/org/eclipse/tractusx/puris/backend/controller/PartnerController.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/org/eclipse/tractusx/puris/backend/controller/PartnerController.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/org/eclipse/tractusx/puris/backend/controller/PartnerController.java
Outdated
Show resolved
Hide resolved
...ain/java/org/eclipse/tractusx/puris/backend/masterdata/logic/service/PartnerServiceImpl.java
Show resolved
Hide resolved
…cify partner by uuid
|
@eschrewe I realized that we need to update the Dependencies of the backend in both places:
reason: the DEPENDENCIES need to be added to the distributables (jar, container) and we can't access the overlying folder during builds :) This will also resolve the dependency check, that fails because it only evaluates the DEPENDENCIES_BACKEND in the root folder. |
Merged
2 tasks
tom-rm-meyer-ISST
requested changes
Oct 9, 2023
...n/java/org/eclipse/tractusx/puris/backend/controller/MaterialPartnerRelationsController.java
Show resolved
Hide resolved
...n/java/org/eclipse/tractusx/puris/backend/controller/MaterialPartnerRelationsController.java
Show resolved
Hide resolved
| }) | ||
| public ResponseEntity<?> addAddress( | ||
| @Parameter(name = "partnerBpnl", description = "The unique BPNL that was assigned to that Partner.", | ||
| example = "BPNL2222222222RR", required = true) @RequestParam() String partnerBpnl, |
There was a problem hiding this comment.
Duplicate of annotations "Parameter" and "RequestParam"
There was a problem hiding this comment.
Yes, there are some ugly redundancies...
I will do some cleaning up
backend/src/main/java/org/eclipse/tractusx/puris/backend/controller/PartnerController.java
Outdated
Show resolved
Hide resolved
tom-rm-meyer-ISST
approved these changes
Oct 9, 2023
tom-rm-meyer-ISST
merged commit b7d23f2
into
eclipse-tractusx:main
9 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added API for
Pre-review checks