Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing base64 decoding in mpr controller #580

Merged
merged 1 commit into from
Oct 2, 2024
Merged

fix: missing base64 decoding in mpr controller #580

merged 1 commit into from
Oct 2, 2024

Conversation

eschrewe
Copy link
Contributor

Description

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
  • Copyright and license header are present on all affected files
  • If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).

tom-rm-meyer-ISST
tom-rm-meyer-ISST approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing!

@tom-rm-meyer-ISST tom-rm-meyer-ISST linked an issue Oct 2, 2024 that may be closed by this pull request
Updating an MPR leads to setting the partner material number to the base64 #579
Closed
@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit a12db3e into eclipse-tractusx:main Oct 2, 2024
13 checks passed
@tom-rm-meyer-ISST tom-rm-meyer-ISST deleted the fix/missingbase64decoding branch October 2, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-rm-meyer-ISST tom-rm-meyer-ISST tom-rm-meyer-ISST approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updating an MPR leads to setting the partner material number to the base64
2 participants
@eschrewe @tom-rm-meyer-ISST