Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation of helm charts #60

Merged
merged 6 commits into from
Oct 31, 2023
Merged

Update documentation of helm charts #60

merged 6 commits into from
Oct 31, 2023

Conversation

PaMarzec
Copy link
Contributor

@PaMarzec PaMarzec commented Oct 26, 2023 •
edited
Loading

Description

This PR adresses the follwing Issues

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@PaMarzec
docs: added missing content and updated docs for install.md's
37949ce 
added missing content for puris/charts/puris/LICENSE and Puris/charts/puris/charts/frontend/.helmignore, updated docs for install.md's in rootfolder, backend and frontend
@PaMarzec
docs: added paragraph for frontend container building workaround in d…
63c7890 
…ocs/DEVELOPMENT.md
@PaMarzec PaMarzec changed the title Docs/add missing helm docs squascht Docs/add missing helm docs Oct 26, 2023
tom-rm-meyer-ISST
tom-rm-meyer-ISST requested changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if there is overall no reason to change the ports in the different files from 3000 to 30000, then please undo :)

frontend/INSTALL.md Outdated Show resolved Hide resolved
@PaMarzec PaMarzec changed the title Docs/add missing helm docs Update documentation of helm charts Oct 27, 2023
@PaMarzec PaMarzec force-pushed the docs/add-missing-helm-docs-squascht branch from 871c504 to 5f96471 Compare October 27, 2023 08:30
@PaMarzec PaMarzec force-pushed the docs/add-missing-helm-docs-squascht branch from de7ec79 to 91e42e8 Compare October 27, 2023 13:25
tom-rm-meyer-ISST
tom-rm-meyer-ISST requested changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't mention all sections where the port has been changed. Sorry for that. Please update.

INSTALL.md Show resolved Hide resolved
backend/INSTALL.md Show resolved Hide resolved
frontend/INSTALL.md Show resolved Hide resolved
tom-rm-meyer-ISST
tom-rm-meyer-ISST approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as discussed. Helm deployment already used 30000er ports. Docker and local used 3000.

@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit f76181a into eclipse-tractusx:main Oct 31, 2023
11 checks passed
@tom-rm-meyer-ISST
Copy link
Contributor

solves #46 #47 #48 #56

This was referenced Oct 31, 2023
Closed
Closed
Closed
Closed
@PaMarzec PaMarzec deleted the docs/add-missing-helm-docs-squascht branch November 2, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-rm-meyer-ISST tom-rm-meyer-ISST tom-rm-meyer-ISST approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PaMarzec @tom-rm-meyer-ISST