Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add workflow for backend unit tests #616

Merged
merged 1 commit into from
Oct 14, 2024
Merged

ci: add workflow for backend unit tests #616

merged 1 commit into from
Oct 14, 2024

Conversation

tom-rm-meyer-ISST
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST commented Oct 2, 2024 •
edited
Loading

Description

To ensure we don't miss existing unit tests during update, I added a workflow to run unit tests in the backend during PR.

Will undo making one test fail after functional review.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
  • Copyright and license header are present on all affected files
  • If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).

@tom-rm-meyer-ISST tom-rm-meyer-ISST changed the base branch from ci/backend-test to main October 2, 2024 16:22
@tom-rm-meyer-ISST tom-rm-meyer-ISST force-pushed the ci/backend-test branch 3 times, most recently from f29eaff to 141bb95 Compare October 2, 2024 16:25
eschrewe
eschrewe suggested changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@eschrewe eschrewe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, thanks very much. I'd just say we better use release versions of those actions.

.github/workflows/unit-test-backend.yaml Show resolved Hide resolved
.../java/org/eclipse/tractusx/puris/backend/common/edc/logic/service/EdcAdapterServiceTest.java Outdated Show resolved Hide resolved
@eschrewe eschrewe self-requested a review October 14, 2024 08:16
mhellmeier
mhellmeier approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@mhellmeier mhellmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhellmeier mhellmeier changed the title Ci: add workflow for backend unit tests ci: add workflow for backend unit tests Oct 14, 2024
@mhellmeier mhellmeier merged commit c93ab55 into eclipse-tractusx:main Oct 14, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eschrewe eschrewe eschrewe approved these changes

@mhellmeier mhellmeier mhellmeier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tom-rm-meyer-ISST @mhellmeier @eschrewe