-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: k8s notifier #375
feat: k8s notifier #375
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but can not verify go section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would love to see some automated test for the implementation.
It also seems, like we would send out emails for fix versions.
Looking at the history on the kubernetes release page, it seems like the release is always updated to the latest patch version.
does colly guarantee a correct order for onHTML? The used tag + css class combination is used a lot on that page
Added a basic unit test to verify returned release version is SemVer. Can't think of any other test, feel free to drop any suggestions. |
There is plenty of things that can be tested. For example:
|
Hi @tomaszbarwicki, If you could resolve the merge conflict, then I'll approve the changes |
@SebastianBezold done |
PR to add Kubernetes release notification. Feature enhances existing 'release notifier' tool which currently supports PostgreSQL release notification. Added specific k8s notification email template content as well as renamed and updated release notifier GitHub Actions workflow for automation.
Updates eclipse-tractusx/sig-infra#320