chore: replace release workflow #400
Conversation
| - name: Tag major and minor versions | ||
| if: ${{ steps.release.outputs.release-automation--release_created }} | ||
| run: | | ||
| git config user.name github-actions[bot] |
There was a problem hiding this comment.
Hi @tomaszbarwicki,
could you please explain, why this manual tagging is necessary, when using the release-please action?
You can have a look at this example: https://github.com/catenax-ng/release-automation-playground/blob/main/.github/workflows/release.yaml#L24
There is almost no manual step necessary except the building an uploading.
I think having this in a single job is maybe also easier than having two jobs and then needing to set outputs
There was a problem hiding this comment.
Hi @SebastianBezold,
the reason of creating tags is because we want as I believe to use release-automation as GitHub action, replacing following: https://github.com/eclipse-tractusx/sig-infra/blob/main/.github/workflows/reusable-quality-checks.yaml therefore we need to create appropriate tags as suggested by
https://github.com/google-github-actions/release-please-action#creating-majorminor-tags
There was a problem hiding this comment.
Ah ok I see! makes sense in our case of releasing the action as well in the same repo.
I think i saw a feature of release-please, that would allow us to replace the version number of the action with the outputs of release please too. Maybe this would be a good next step then, since it feels odd, that we only need that for the action.yaml file, which we might forget to increment in the PR.
In such cases, we would tag the commit, but would create a following commit, that then bumps the version used in the action. Could lead to the action being behind one version always :)
PR to introduce release workflow based on release-please. The workflow replaces existing one, adds more transparency and focuses on release-automation tool only. It also fixes building windows binaries with .exe
Updates eclipse-tractusx/sig-infra#392