Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:Removed TODOs and comments #206

Merged
merged 1 commit into from
Aug 29, 2023
Merged

feat:Removed TODOs and comments #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...g/eclipse/tractusx/semantics/registry/controller/AssetAdministrationShellApiDelegate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@ public ResponseEntity<GetAssetAdministrationShellDescriptorsResult> getAllAssetA
}

@Override
// new todo: correct implementation
public ResponseEntity<GetSubmodelDescriptorsResult> getAllSubmodelDescriptorsThroughSuperpath( byte[] aasIdentifier, Integer limit, String cursor, @RequestHeader String externalSubjectId ) {
Shell savedShell = shellService.findShellByExternalIdAndExternalSubjectId(getDecodedId( aasIdentifier ),getExternalSubjectIdOrEmpty(externalSubjectId));
SubmodelCollectionDto dto = shellService.findAllSubmodel( limit,cursor, savedShell);
Expand Down
9 changes: 4 additions & 5 deletions ...est/java/org/eclipse/tractusx/semantics/registry/AbstractAssetAdministrationShellApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.*;


// TODO: Include also checking the expected content which is currently commented
@SpringBootTest
@AutoConfigureMockMvc
@EnableConfigurationProperties( RegistryProperties.class)
Expand Down Expand Up @@ -88,8 +87,8 @@ protected void performSubmodelCreateRequest(String payload, String shellIdentifi
.with(jwtTokenFactory.allRoles())
)
.andDo(MockMvcResultHandlers.print())
.andExpect(status().isCreated());
// .andExpect(content().json(payload));
.andExpect(status().isCreated())
.andExpect(content().json(payload));
}

/**
Expand Down Expand Up @@ -117,8 +116,8 @@ protected void performShellCreateRequest(String payload, String expectation) thr
.with(jwtTokenFactory.allRoles())
)
.andDo(MockMvcResultHandlers.print())
.andExpect(status().isCreated());
// .andExpect(content().json(expectation));
.andExpect(status().isCreated())
.andExpect(content().json(expectation));
}


Expand Down
Loading