Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Extend DTR APIs for Access management - Clean-up #310

Conversation

istvan-nagy-epam
Copy link
Contributor

@istvan-nagy-epam istvan-nagy-epam commented Feb 12, 2024

Description

  • Moves ShellRepository.findExternalShellIdsByIdentifiersByExactMatch to ShellIdentifierRepository
  • Fixes service method listing all shells

Related to #287

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

- Moves ShellRepository.findExternalShellIdsByIdentifiersByExactMatch to ShellIdentifierRepository
- Fixes service method listing all shells
Copy link

sonarcloud bot commented Feb 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@tunacicek tunacicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tunacicek tunacicek merged commit 27e1ba6 into eclipse-tractusx:main Feb 12, 2024
8 checks passed
@istvan-nagy-epam istvan-nagy-epam deleted the feature/287-extend-dtr-apis-for-access-management__06-clean-up branch February 12, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants