Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement new DTR validation API (for submodel request) #315

Conversation

istvan-nagy-epam
Copy link
Contributor

Description

  • Removes unnecessary access control service method
  • Implements new REST endpoint and service method for submodel endpoint address access control handling
  • Adds new repository method for fetching shells by endpoint address
  • Configures new OAuth2 role
  • Adds new tests

Fixes: #289

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@istvan-nagy-epam istvan-nagy-epam force-pushed the feature/289-implement-new-dtr-validation-api branch 2 times, most recently from e618ef3 to 238cafe Compare February 14, 2024 08:47
@tunacicek
Copy link
Contributor

@istvan-nagy-epam : Could you please add the new role in the documentation:
https://github.com/eclipse-tractusx/sldt-digital-twin-registry/tree/main/docs#:~:text=1.0-,Authentication,-%26%20Authorization

- Removes unnecessary access control service method
- Implements new REST endpoint and service method for submodel endpoint address access control handling
- Adds new repository method for fetching shells by endpoint address
- Adds new tests
- Adds new role to documentation
@istvan-nagy-epam istvan-nagy-epam force-pushed the feature/289-implement-new-dtr-validation-api branch from 238cafe to af29ba3 Compare February 14, 2024 14:15
Copy link

sonarcloud bot commented Feb 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@tunacicek tunacicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tunacicek tunacicek merged commit cb2e2bc into eclipse-tractusx:main Feb 14, 2024
8 checks passed
@istvan-nagy-epam istvan-nagy-epam deleted the feature/289-implement-new-dtr-validation-api branch February 14, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement new DTR validation API (for submodel request)
2 participants