Rebase and added all changes for Cognito support #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tunacicek
reviewed
Jun 21, 2024
...d/src/main/java/org/eclipse/tractusx/semantics/registry/security/AuthorizationEvaluator.java
Show resolved
Hide resolved
|
Hi @peissing , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature:
DTR is at the moment only able to use Keycloak as for authentication
This feature enable DTR to use also AWS Cognito
The whole functionality and how to configure is described in the file COGNITO.md that is contained in this pull request.
The request contains several new and modified classes including unit tests.
The old class AuthorizationEvaluator is now abstract and the base class for different Evaluators. At the moment there are implementations for Keycloak and for Cognito.
I am not an expert for Helm charts, but I tried to integrate it also in those files. But this must be checked if I did it in a correct way.
Hello @tunacicek,
thank you again for reviewing the old pull request.
I did now a complete rebase and added all the changes again.