Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(processWorker): add missing registrations #338

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Feb 7, 2025

Description

Add missing registrations for process worker

Why

The process worker doesn't start due to missing registrations

Issue

N/A

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have added copyright and license headers, footers (for .md files) or files (for images)

@Phil91 Phil91 requested a review from evegufy February 7, 2025 15:45
@Phil91 Phil91 changed the base branch from main to changelog/v1.2.0-rc.2 February 7, 2025 15:45
@evegufy evegufy changed the base branch from changelog/v1.2.0-rc.2 to release/v1.3.0-rc.2 February 7, 2025 15:47
@Phil91 Phil91 force-pushed the bugfix/process-worker branch from 6661e78 to 5431478 Compare February 7, 2025 15:48
Copy link

sonarqubecloud bot commented Feb 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@Phil91
Copy link
Member Author

Phil91 commented Feb 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions 0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

no test coverage because the added class just returns a completed task.

@Phil91 Phil91 merged commit 3b1d88e into release/v1.3.0-rc.2 Feb 7, 2025
9 of 10 checks passed
@Phil91 Phil91 deleted the bugfix/process-worker branch February 7, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

2 participants