feat: update IAM to seed URLs, clients secrets, etc. dynamically #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shouldn't be obsolete since R2412
evegufy
changed the title
9 tasks
as long as post-install testdata-upload-job of tx-data-provider still uses it for chart testing
evegufy
requested review from
matbmoser,
saudkhan116,
mgarciaLKS and
CDiezRodriguez
|
We will review that :) Thx Evelyn |
matbmoser
approved these changes
Oct 28, 2024
| bpn: BPNL00000000BJTL | ||
| initContainer: | ||
| image: | ||
| name: docker.io/tractusx/umbrella-init-container:1.1.0-init |
There was a problem hiding this comment.
In dockerhub the image with tag 1.1.0 is missing. I tried building the image of init-container and using it, and it works fine.
There was a problem hiding this comment.
I understand that the 1.1.0-init tag still needs to be created so that the following GitHub Actions can generate it: build-init-container
There was a problem hiding this comment.
I just pushed the tag https://github.com/eclipse-tractusx/tractus-x-umbrella/releases/tag/1.1.0-init, so that then new init container got built
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update keycloak instances to seed URLs, clients secrets, etc. dynamically
seeding of the test service accounts for the EDC <--> MIW connection is be obsolete since R2412 but I updated and didn't remove the ad hoc init container to enable the seeding of those test service accounts, in case it's needed again
can be uncommented of the post-install testdata-upload-job of tx-data-provider doesn't use it during chart testing anymore
#126
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: