chore: add dataprovider charts #53
Conversation
charts/submodelservers/values.yaml
Outdated
| fullnameOverride: | ||
|
|
||
| image: | ||
| repository: ghcr.io/catenax-ng/catenax-at-home/provider-backend-service |
There was a problem hiding this comment.
Is there nothing equivalent in Eclipse Tractus-X.
If no, we should move this asap. The catenax-ng org will potentially be gone.
The repo itself states, that it is out of date. There is also no 3rd party dependency check, which we would need to do for it.
So in my opinion, we cannot use this repo as dependency here
There was a problem hiding this comment.
I agree and tried to find something similar but it looks like this was not migrated to Eclipse Tractus-X.
The "proper" way would probably be to use one of the AASX Submodel Servers mentioned in the Digital Twin Kit
Since none of these Projects provide their own Helm Charts we cannot add them easily and I'm not familiar with the APIs and how to use them or integrate them with the existing test data upload script we were using in the IRS.
There was a problem hiding this comment.
Ok understood,
@stephanbcbauer, @danielmiehle, @Siegfriedk, @giterrific: What is your view from a project lead perspective?
Do we need a new repo/product, to pick up these missing things. I think we definitely need that for a proper way forward.
@AngelikaWittek: Do you see anything, that would prevent us from using the service provided by catenax-ng/catenax-at-home. I guess it as least proper IP checks right?
There was a problem hiding this comment.
@SebastianBezold is it about the image itself? We could fork the repo (no clue if this is legally okay for EF), we could clone the image into ours (to have it for test purposes only), we could fork the docker file and build it ourselves?
There was a problem hiding this comment.
Thank you for the insights. Since we only need a small docker image with create and get capabilities, we decided to implement this ourselves. As discussed with @jzbmw I prepared a PR to add this to this repo: #54
I will remove the submodelservers chart form this branch. It will be added in scope of the other PR
…r-charts # Conflicts: # charts/umbrella/Chart.yaml
# Conflicts: # charts/umbrella/Chart.yaml # charts/umbrella/values.yaml
…r-charts # Conflicts: # charts/umbrella/Chart.yaml # charts/umbrella/values.yaml
|
Installing seems to be failing due to |
Doesn't seem like we have any finetuning going on. You can always finetune the CPU requests. Independent of it, we can also use large runners. |
change to `helm install` instead of `ct install` to don't run into that error anymore because when using helm install (also on local Minikube) the chart (for instance for this PR #53) installs without error. also: add an informational step to describe the node for more awareness about available resources in the future and upgrade some actions.
There was a problem hiding this comment.
Looks good in general 👍 just essentially the same point as already for the simple-data-backend: we need to be able to test the tx-data-provider via workflow, see #64, otherwise it's to hard to maintain and currently the install fails https://github.com/eclipse-tractusx/tractus-x-umbrella/actions/runs/8705281375/job/23875363023 (also on my local), could you please look into that?
…a-provider chore: add tx-data-provider to helm checks
|
Hey @ds-jhartmann! The controlplane and dataplane pods are throwing NullPointerExceptions here and here that should be investigated. |
Thanks for the hint. I already saw this and I'm working on moving the vault to the tx-data-provider chart. EDC required a vault connection to start |
# Conflicts: # charts/umbrella/Chart.yaml
Description
Relates to eclipse-tractusx/item-relationship-service#375
Not included
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: