Skip to content

Commit

Permalink
Merge pull request #59 from catenax-ng/fix/Remove_overwritten_default…
Browse files Browse the repository at this point in the history
…_values_from_subchart

Remove unnecessarily overwriting default subchart values
  • Loading branch information
SebastianBezold authored Nov 28, 2023
2 parents 50252e8 + c450fa0 commit 3549e6f
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 17 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/helm-chart-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ jobs:
helm repo add pgadmin4 https://helm.runix.net
helm repo add bitnami https://charts.bitnami.com/bitnami
helm repo add tractusx-dev https://eclipse-tractusx.github.io/charts/dev
helm install country-risk tractusx-dev/country-risk --version ${{ github.event.inputs.upgrade_from }}
helm install country-risk tractusx-dev/country-risk --version ${{ github.event.inputs.upgrade_from || '1.1.0' }}
helm dependency update charts/country-risk
helm upgrade country-risk charts/country-risk
if: github.event_name != 'pull_request' || steps.list-changed.outputs.changed == 'true'
2 changes: 1 addition & 1 deletion charts/country-risk/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
apiVersion: v2
name: country-risk
type: application
version: 3.0.3
version: 3.0.4
appVersion: "1.2.1"
description: A Helm chart for deploying the Country Risk service
home: https://github.com/eclipse-tractusx/vas-country-risk-frontend
Expand Down
15 changes: 0 additions & 15 deletions charts/country-risk/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,6 @@
country-risk-frontend:
replicaCount: 1

image:
registry: "tractusx"
# -- Name of the docker image
name: "vas-country-risk"
pullPolicy: Always
# -- Overrides the image tag whose default is the chart appVersion.
tag: ""

certificate:
# -- Hostname for the certificate
host: "frontend.countryrisk.example.net"
Expand Down Expand Up @@ -154,13 +146,6 @@ country-risk-frontend:
country-risk-backend:

replicaCount: 1
image:
registry: "tractusx"
# -- Name of the docker image
name: "vas-country-risk-backend"
pullPolicy: Always
# -- Overrides the image tag whose default is the chart appVersion.
tag: ""

certificate:
# -- Hostname for the certificate
Expand Down

0 comments on commit 3549e6f

Please sign in to comment.