Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Kotlin DSL for builder functions #21

Merged
merged 4 commits into from
Mar 13, 2024

Conversation

dddj698
Copy link
Contributor

@dddj698 dddj698 commented Mar 9, 2024

Replace UAttributesBuilder with Kotlin DSL type safe builder functions
Replace UResourceBuilder with Kotlin DSL type safe builder functions
Update UCloudEventAttributes to use Kotlin DSL type safe builder instead
Replace CallOptionsBuilder with Kotlin DSL type safe builder instead
Replace UPayloadBuilder with Kotlin DSL type safe builder functions.

Fixes #10

author: @mikaelperrin
co-author: @dddj698

Replace UAttributesBuilder with Kotlin DSL type safe builder functions
Replace UResourceBuilder with Kotlin DSL type safe builder functions
Update UCloudEventAttributes to use Kotlin DSL type safe builder instead
Replace CallOptionsBuilder with Kotlin DSL type safe builder instead
Copy link

@mikaelperrin mikaelperrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a minor comment

@stevenhartley stevenhartley merged commit c9bc5f7 into eclipse-uprotocol:main Mar 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace java-like builders around protobuf types by kotlin type safe builders that leverage kotlin DSL
3 participants