-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation of up-linux-streamer-plugin as a Zenoh Plugin #17
Initial implementation of up-linux-streamer-plugin as a Zenoh Plugin #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not able to run your plugins (Not sure about how SOME/IP works). But it seems like everything is fine in Zenoh example plugins.
I would suggest we can remove all the test code and use the same way in Zenoh example plugins. Then it's easier to do the comparison.
Hey CY -- can you reopen this PR? Still planning to clean up and move from draft status when ready. |
Ah, sorry. I didn't notice that merging eclipse-uprotocol/up-transport-zenoh-rust#50 will close the PR. |
Interesting haha Learn something new each day 😆 |
43da570
to
3574b86
Compare
@PLeVasseur Let me know if this is ready for review. Not sure whether you still want to add something. |
Yup! Please feel free to review. There may be some small changes that come in here as unit tests / integration tests are added, but hopefully not much. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some nits
748422e
to
00326fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It would be better to have an initial version first and update later.
Implements [#23]
* Update hello-world-protos to point to fixed COVESA repo * Add copyright info and update incorrect 2023 copyright to 2024 * Move examples to stand-alone crate as they can be used with either of the stand-alone binary and plugin version of the streamer. * Use plugins feature of Zenoh crate to silence error
00326fb
to
12b80bb
Compare
Issues
Currently need to compile own version of Zenoh to get compatible zenohd (Zenoh Router)
Note the README.md under up-linux-streamer-plugin
I'm assuming as Zenoh releases 1.0.0 this will become resolved as it looks like they used minimum supported Rust version (MSRV) of 1.75.0 in their alpha branches for 1.0.0.
Note issue #43, wherein we will build a compatible Zenoh Router (zenohd)