Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation of up-linux-streamer-plugin as a Zenoh Plugin #17

Conversation

PLeVasseur
Copy link
Contributor

@PLeVasseur PLeVasseur commented Jun 24, 2024

Issues

Currently need to compile own version of Zenoh to get compatible zenohd (Zenoh Router)

Note the README.md under up-linux-streamer-plugin

I'm assuming as Zenoh releases 1.0.0 this will become resolved as it looks like they used minimum supported Rust version (MSRV) of 1.75.0 in their alpha branches for 1.0.0.

Note issue #43, wherein we will build a compatible Zenoh Router (zenohd)

Copy link

@evshary evshary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not able to run your plugins (Not sure about how SOME/IP works). But it seems like everything is fine in Zenoh example plugins.
I would suggest we can remove all the test code and use the same way in Zenoh example plugins. Then it's easier to do the comparison.

up-linux-streamer-plugin/src/lib.rs Outdated Show resolved Hide resolved
up-linux-streamer-plugin/src/lib.rs Outdated Show resolved Hide resolved
@PLeVasseur
Copy link
Contributor Author

Hey CY -- can you reopen this PR?

Still planning to clean up and move from draft status when ready.

@evshary
Copy link

evshary commented Jun 26, 2024

Ah, sorry. I didn't notice that merging eclipse-uprotocol/up-transport-zenoh-rust#50 will close the PR.
It seems like bugs on GitHub?

@evshary evshary reopened this Jun 26, 2024
@PLeVasseur
Copy link
Contributor Author

Interesting haha Learn something new each day 😆

@PLeVasseur PLeVasseur force-pushed the feature/up-linux-streamer-as-zenoh-plugin branch from 43da570 to 3574b86 Compare June 26, 2024 19:27
@evshary
Copy link

evshary commented Jul 8, 2024

@PLeVasseur Let me know if this is ready for review. Not sure whether you still want to add something.

@PLeVasseur
Copy link
Contributor Author

@PLeVasseur Let me know if this is ready for review. Not sure whether you still want to add something.

Yup! Please feel free to review. There may be some small changes that come in here as unit tests / integration tests are added, but hopefully not much.

Copy link

@evshary evshary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some nits

example-utils/hello-world-protos/Cargo.toml Outdated Show resolved Hide resolved
example-utils/hello-world-protos/build.rs Outdated Show resolved Hide resolved
up-linux-streamer-plugin/README.md Show resolved Hide resolved
up-linux-streamer-plugin/README.md Show resolved Hide resolved
up-linux-streamer-plugin/src/lib.rs Show resolved Hide resolved
up-linux-streamer-plugin/README.md Outdated Show resolved Hide resolved
up-linux-streamer-plugin/vsomeip-configs/mE_client.json Outdated Show resolved Hide resolved
up-linux-streamer/examples/mE_client.rs Show resolved Hide resolved
@PLeVasseur PLeVasseur linked an issue Aug 13, 2024 that may be closed by this pull request
@PLeVasseur PLeVasseur force-pushed the feature/up-linux-streamer-as-zenoh-plugin branch from 748422e to 00326fb Compare August 13, 2024 23:23
@PLeVasseur PLeVasseur marked this pull request as ready for review August 13, 2024 23:35
Copy link

@evshary evshary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
It would be better to have an initial version first and update later.

* Update hello-world-protos to point to fixed COVESA repo
* Add copyright info and update incorrect 2023 copyright to 2024
* Move examples to stand-alone crate as they can be used with either of the stand-alone binary and plugin version of the streamer.
* Use plugins feature of Zenoh crate to silence error
@PLeVasseur PLeVasseur force-pushed the feature/up-linux-streamer-as-zenoh-plugin branch from 00326fb to 12b80bb Compare August 14, 2024 12:32
@PLeVasseur PLeVasseur merged commit 541160e into eclipse-uprotocol:main Aug 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implemented in a Zenoh plugin
2 participants