Update Feature Files and Test Agents to 1.5.8 #80

matthewd0123 · 2024-07-09T21:02:56Z

Update the following feature files to 1.5.8
- UriValidator.feature
- UAttributesValidator.feature
- UriSerializer.feature
- UriDeserializer.feature
- UUIDSerializer.feature
- UUIDDeserializer.feature
- RegisterAndUnregister.feature
- RegisterAndSend.feature
- RegisterAndInvoke.feature
Update Java, Python and Rust Test Agents to support 1.5.8
Update Test Manager to use 1.5.8 compatible APIs
Remove feature files and code removed in move from 1.5.7->1.5.8

* Align UriValidator test with v1.5.8 * Update Python and Java TAs to work with UriValidator * Create skeleton for 1.5.8 version of SocketUTransports in Python and Java (still requires work after this PR) * Update Test Manager port (was causing issues locally, changing it fixed the issue) * Remove some deprecated code from Python and Java Test Agents

* Align UUIDValidator test with v1.5.8

* Update UAttributesValidator Feature file to 1.5.8 * Update Python Test Agent to align with 1.5.8

* Remove Long and Micro URI references in code * Add new UriSerializer and UriDeserializer feature files for 1.5.8 * Update python and java to align to uriserializer and deserializer for 1.5.8

Since up-java doesn't use is_notification_destination, this has been removed from the feature files and from the test agents

* Update UUIDSerializer and UUIDDeserializer feature files to align with 1.5.8 * Update python and java test agents to align with 1.5.8 for uuid serializer and deserializer

* Update support for Rust, Python, Java Test Agents to 1.5.8 * Update register_and_unregister feature file for 1.5.8

* Update registerandsend feature file to 1.5.8 * update step implementations to support updates to 1.5.8

matthewd0123 · 2024-07-09T21:03:09Z

#79

* Update registerandinvoke feature file to 1.5.8 * Update Java and Python Test Agents to support 1.5.8

DivyaVuppala · 2024-07-11T15:48:05Z

up_client_socket/python/socket_transport.py

@@ -161,27 +157,21 @@ def send(self, message: UMessage) -> UStatus:
            return UStatus(code=UCode.INTERNAL, message=f"INTERNAL ERROR: {e}")
        return UStatus(code=UCode.OK, message="OK")

-    def register_listener(self, topic: UUri, listener: UListener) -> UStatus:
+    def register_listener(self, source_filter: UUri, listener: UListener, sink_filer: UUri = None) -> UStatus:


my understanding is to consider both source and sink filter while registering... Not sure how the exact flow looks like in terms each of the filter.
This is important to have a combination of source filter and sink filter to store listeners, for service to send the response to the source that has initiated the request.

* Make updates from Divya Vuppala's comments.

* Update socket transport for rust to 1.5.8

gregmedd

This pull request is far too large for a meaningful review. This must be split into smaller pull requests before it can be accepted into this project.

matthewd0123 · 2024-07-18T20:14:29Z

@gregmedd totally agree, I have this in draft because I'm collecting all 1.5.8 changes. Will split once it's ready for review

gregmedd · 2024-07-18T20:19:58Z

My recommendation for splitting this PR would be to provide one PR for each 1.5.8/1.6.0 language update, then to add new features as one or a series of pull requests after those.

agosh01 · 2024-07-19T01:25:41Z

test_manager/features/tests/transport_rpc/register_and_send.feature

    And sets "attributes.source.ue_version_major" to "1"
    And sets "attributes.source.resource_id" to "32769"
    And sets "attributes.priority" to "UPRIORITY_CS1"
    And sets "attributes.type" to "UMESSAGE_TYPE_PUBLISH"
+    And sets "attributes.commstatus" to "OK"


remove this not allowed for send umessage

* Allow for arbitrary number of Test Agents in a given test * Update rust to 0.1.1 release * Remove invoke_method, as it is L2 API * Add few tests for streamer

* Update Python Test Agent * Update Python Test Manager * Update TCK Step Implementations * Update uuid_validator feature

…atthewd0123/up-tck into feature/update_python_to_1.5.8

* Align UriValidator test with v1.5.8 * Update Python and Java TAs to work with UriValidator * Create skeleton for 1.5.8 version of SocketUTransports in Python and Java (still requires work after this PR) * Update Test Manager port (was causing issues locally, changing it fixed the issue) * Remove some deprecated code from Python and Java Test Agents

* Align UUIDValidator test with v1.5.8

* Update UAttributesValidator Feature file to 1.5.8 * Update Python Test Agent to align with 1.5.8

* Remove Long and Micro URI references in code * Add new UriSerializer and UriDeserializer feature files for 1.5.8 * Update python and java to align to uriserializer and deserializer for 1.5.8

Since up-java doesn't use is_notification_destination, this has been removed from the feature files and from the test agents

* Update UUIDSerializer and UUIDDeserializer feature files to align with 1.5.8 * Update python and java test agents to align with 1.5.8 for uuid serializer and deserializer

* Update support for Rust, Python, Java Test Agents to 1.5.8 * Update register_and_unregister feature file for 1.5.8

* Update registerandsend feature file to 1.5.8 * update step implementations to support updates to 1.5.8

* Update registerandinvoke feature file to 1.5.8 * Update Java and Python Test Agents to support 1.5.8

* Make updates from Divya Vuppala's comments.

* Update socket transport for rust to 1.5.8

* Allow for arbitrary number of Test Agents in a given test * Update rust to 0.1.1 release * Remove invoke_method, as it is L2 API * Add few tests for streamer

…m/matthewd0123/up-tck into feature/register_and_invoke_1.5.8

matthewd0123 added 8 commits July 8, 2024 15:54

Update UUIDValidator to 1.5.8

af48e3e

* Align UUIDValidator test with v1.5.8

Update UAttributesValidator to 1.5.8

9ffa236

* Update UAttributesValidator Feature file to 1.5.8 * Update Python Test Agent to align with 1.5.8

Update UriSerializer and UriDeserializer 1.5.8

2636a61

* Remove Long and Micro URI references in code * Add new UriSerializer and UriDeserializer feature files for 1.5.8 * Update python and java to align to uriserializer and deserializer for 1.5.8

Remove is_notification_destination

deae544

Since up-java doesn't use is_notification_destination, this has been removed from the feature files and from the test agents

Update UUIDSerializer/Deserializer to 1.5.8

12a6065

* Update UUIDSerializer and UUIDDeserializer feature files to align with 1.5.8 * Update python and java test agents to align with 1.5.8 for uuid serializer and deserializer

Update RegisterAndUnregister to 1.5.8

9ea757a

* Update support for Rust, Python, Java Test Agents to 1.5.8 * Update register_and_unregister feature file for 1.5.8

Update RegisterAndSend to 1.5.8

76a0b73

* Update registerandsend feature file to 1.5.8 * update step implementations to support updates to 1.5.8

Update RegisterAndInvoke to 1.5.8

3bac7dd

* Update registerandinvoke feature file to 1.5.8 * Update Java and Python Test Agents to support 1.5.8

matthewd0123 force-pushed the feature/register_and_invoke_1.5.8 branch from 3b2643d to 3bac7dd Compare July 9, 2024 21:03

matthewd0123 changed the title ~~Update RegisterAndInvoke to 1.5.8~~ Update Feature Files and Test Agents to 1.5.8 Jul 11, 2024

DivyaVuppala reviewed Jul 11, 2024

View reviewed changes

Make updates based on comments

c72d538

* Make updates from Divya Vuppala's comments.

matthewd0123 force-pushed the feature/register_and_invoke_1.5.8 branch from e42f544 to c72d538 Compare July 15, 2024 13:54

Update rust socket transport to 1.5.8

7f30d18

* Update socket transport for rust to 1.5.8

matthewd0123 marked this pull request as draft July 18, 2024 16:37

matthewd0123 force-pushed the feature/register_and_invoke_1.5.8 branch 7 times, most recently from 6186617 to 818c036 Compare July 18, 2024 18:39

gregmedd requested changes Jul 18, 2024

View reviewed changes

gregmedd assigned matthewd0123 Jul 18, 2024

agosh01 reviewed Jul 19, 2024

View reviewed changes

Changes to support streamer

f72166d

* Allow for arbitrary number of Test Agents in a given test * Update rust to 0.1.1 release * Remove invoke_method, as it is L2 API * Add few tests for streamer

matthewd0123 force-pushed the feature/register_and_invoke_1.5.8 branch from 818c036 to f72166d Compare July 19, 2024 15:25

matthewd0123 and others added 20 commits July 19, 2024 11:39

Update Python and SocketPython to 1.5.8

abb5ea1

* Update Python Test Agent * Update Python Test Manager * Update TCK Step Implementations * Update uuid_validator feature

Update Python and SocketPython to 1.5.8

c2c5229

* Update Python Test Agent * Update Python Test Manager * Update TCK Step Implementations * Update uuid_validator feature

Merge branch 'feature/update_python_to_1.5.8' of https://github.com/m…

c6dab1b

…atthewd0123/up-tck into feature/update_python_to_1.5.8

moderate changes

6b8c6e9

Update UUIDValidator to 1.5.8

2a0f87d

* Align UUIDValidator test with v1.5.8

Update UAttributesValidator to 1.5.8

8967111

* Update UAttributesValidator Feature file to 1.5.8 * Update Python Test Agent to align with 1.5.8

Update UriSerializer and UriDeserializer 1.5.8

ffeb97a

* Remove Long and Micro URI references in code * Add new UriSerializer and UriDeserializer feature files for 1.5.8 * Update python and java to align to uriserializer and deserializer for 1.5.8

Remove is_notification_destination

05e6a8f

Since up-java doesn't use is_notification_destination, this has been removed from the feature files and from the test agents

Update UUIDSerializer/Deserializer to 1.5.8

288169f

* Update UUIDSerializer and UUIDDeserializer feature files to align with 1.5.8 * Update python and java test agents to align with 1.5.8 for uuid serializer and deserializer

Update RegisterAndUnregister to 1.5.8

6f047f5

* Update support for Rust, Python, Java Test Agents to 1.5.8 * Update register_and_unregister feature file for 1.5.8

Update RegisterAndSend to 1.5.8

626d81f

* Update registerandsend feature file to 1.5.8 * update step implementations to support updates to 1.5.8

Update RegisterAndInvoke to 1.5.8

3a3084e

* Update registerandinvoke feature file to 1.5.8 * Update Java and Python Test Agents to support 1.5.8

Make updates based on comments

1ef4fb4

* Make updates from Divya Vuppala's comments.

Update rust socket transport to 1.5.8

3d7fd0f

* Update socket transport for rust to 1.5.8

Changes to support streamer

204c8c9

* Allow for arbitrary number of Test Agents in a given test * Update rust to 0.1.1 release * Remove invoke_method, as it is L2 API * Add few tests for streamer

moderate changes

e802fef

Merge branch 'feature/register_and_invoke_1.5.8' of https://github.co…

83ce12b

…m/matthewd0123/up-tck into feature/register_and_invoke_1.5.8

GO

6803734

stuff

d31e880

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Feature Files and Test Agents to 1.5.8 #80

Update Feature Files and Test Agents to 1.5.8 #80

matthewd0123 commented Jul 9, 2024 •

edited

Loading

matthewd0123 commented Jul 9, 2024

DivyaVuppala Jul 11, 2024

gregmedd left a comment

matthewd0123 commented Jul 18, 2024

gregmedd commented Jul 18, 2024

agosh01 Jul 19, 2024

Update Feature Files and Test Agents to 1.5.8 #80

Are you sure you want to change the base?

Update Feature Files and Test Agents to 1.5.8 #80

Conversation

matthewd0123 commented Jul 9, 2024 • edited Loading

matthewd0123 commented Jul 9, 2024

DivyaVuppala Jul 11, 2024

Choose a reason for hiding this comment

gregmedd left a comment

Choose a reason for hiding this comment

matthewd0123 commented Jul 18, 2024

gregmedd commented Jul 18, 2024

agosh01 Jul 19, 2024

Choose a reason for hiding this comment

matthewd0123 commented Jul 9, 2024 •

edited

Loading