Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Java and SocketTransportJava to 1.5.8 #87

Merged
merged 4 commits into from
Jul 31, 2024
Merged

Update Java and SocketTransportJava to 1.5.8 #87

merged 4 commits into from
Jul 31, 2024

Conversation

matthewd0123
Copy link
Contributor

No description provided.

@matthewd0123
Copy link
Contributor Author

#79

neelam-kushwah
neelam-kushwah reviewed Jul 26, 2024
View reviewed changes
Copy link
Contributor

@neelam-kushwah neelam-kushwah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of manually adding the socket transport here, can we pull it from the up-transport-socket repo?

agosh01
agosh01 reviewed Jul 26, 2024
View reviewed changes
Copy link
Member

@agosh01 agosh01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the PR looks good. Please find my comments below:

test_agent/java/src/main/java/org/eclipse/uprotocol/TestAgent.java Outdated Show resolved Hide resolved
test_agent/java/src/main/java/org/eclipse/uprotocol/TestAgent.java Outdated Show resolved Hide resolved
up_client_socket/java/src/main/java/org/eclipse/uprotocol/SocketUTransport.java Show resolved Hide resolved
up_client_socket/java/src/main/java/org/eclipse/uprotocol/SocketUTransport.java Show resolved Hide resolved
@matthewd0123
Resolve Comments
4dcfb0e 
* Change INVALID_ARGUMENT to FAILED_PRECONDITION
* Remove invokemethod constant
agosh01
agosh01 approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@agosh01 agosh01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neelam-kushwah neelam-kushwah merged commit 31dc933 into eclipse-uprotocol:main Jul 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agosh01 agosh01 agosh01 approved these changes

@neelam-kushwah neelam-kushwah neelam-kushwah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
uProtocol Test Compatibility Kit Development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewd0123 @neelam-kushwah @agosh01