Add integration tests #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PLeVasseur
reviewed
Nov 1, 2024
| @@ -20,8 +20,9 @@ on: | |||
| paths: | |||
| - "src/**" | |||
| - "Cargo.*" | |||
| workflow_call: | |||
| workflow_dispatch: | |||
| - "tests/**" | |||
| @@ -19,7 +19,11 @@ cargo test | |||
|
|
|||
| ### Running the Examples | |||
|
|
|||
| 1. Start an MQTT broker (e.g. mosquitto) | |||
| 1. Start an MQTT broker or use the included Mosquitto broker: | |||
| ```bash | |||
| mosquitto: | ||
| image: eclipse-mosquitto:2.0 | ||
| volumes: | ||
| # read-only prevents the container changing file owners on the host |
Lets see. It looks like I can copypaste a lot from zenoh but first Ill try to understand whats going on there a bit. |
PLeVasseur
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Thanks @ValMobBIllich! A good starting point. LGTM
Reminder to us that we should do #9 to improve integration test coverage.
Could you now author a meaningful commit history so I can perform a merge commit?
ValMobBIllich
force-pushed
the
add_integration_tests
branch
from
a623ef3
to
ca070aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a first integration test for the unencrypted publish/ subscribe case. Should more or less follow the conventions from the integration tests in the zenoh transport repo.
The test pipeline now includes docker composing a mosquitto broker and only runs the tests after the broker is reachable.
The encrypted case and possibly some tests for error cases are coming as soon as I can figure out how to configure the broker properly... Either in this PR or in a later one.