New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve message dispatching & small refactorings #8

Open

jjj-vtm wants to merge 2 commits into eclipse-uprotocol:main from jjj-vtm:dispatch_improvement

jjj-vtm commented Nov 7, 2024

Hi,

I made some small improvements dispatching messages to a listener. Basically:

Drop locks early, especially drop them before the dispatch ie. on_receive call
Dispatch is done on a separate task so that a slow listener does not slow down.
Todo to handle the connection drop case correctly.

Cheers,

Jan

jjj-vtm added 2 commits

November 7, 2024 15:17


          Improve message dispatching & small refactorings

1e579bf


          Reformat

961a7e5

Contributor

PLeVasseur commented Nov 15, 2024 •

edited

Loading

Hey @jjj-vtm -- sorry, I missed this! Can you rebase and then I can make some time to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet