Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add support for app manifest v3 #30

Merged
merged 5 commits into from
Aug 21, 2023
Merged

Feature: Add support for app manifest v3 #30

merged 5 commits into from
Aug 21, 2023

Conversation

doosuu
Copy link
Member

@doosuu doosuu commented Aug 19, 2023

PR adds support for app manifest v3 while still keeping backwards compatibility support for manifests < v3

@doosuu doosuu requested a review from MP91 August 19, 2023 10:44
@github-actions
Copy link

github-actions bot commented Aug 19, 2023

File Coverage Lines Branches
All files 88% 90% 86%
vehicle-model-lifecycle/src/download_vspec.py 95% 95% 96%
vehicle-model-lifecycle/src/generate_model.py 54% 59% 50%

Minimum allowed coverage is 80%

Generated by 🐒 cobertura-action against 8b92163

@MP91
Copy link
Contributor

MP91 commented Aug 21, 2023

another small request since we currently touching this repo anyways: could you remove the pspester.pester-test extension from setup/src/python/common/devcontainer.json?

We don't have powershell at all and it is currently always showing a notification when starting the devcontainer...

If you disagree, it is also fine, than I create a new PR with the change :)

MP91
MP91 previously approved these changes Aug 21, 2023
Copy link
Contributor

@MP91 MP91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@doosuu doosuu force-pushed the manifest-v3 branch 2 times, most recently from de9800a to 264ecd9 Compare August 21, 2023 12:25
Copy link
Contributor

@MP91 MP91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doosuu doosuu merged commit 65a932a into main Aug 21, 2023
5 checks passed
@doosuu doosuu deleted the manifest-v3 branch August 21, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants