fix url parser to correctly handle unix domain sockets

eclipse-velocitas · Nov 18, 2024 · e710548 · e710548
1 parent 216a7f2
commit e710548
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 0 deletions.
diff --git a/.gitignore b/.gitignore
@@ -69,3 +69,6 @@ conan_imports_manifest.txt
 # auto-generated SDK version
 version.txt
 logs
+
+# Velocitas home
+.velocitas
diff --git a/sdk/src/sdk/Utils.cpp b/sdk/src/sdk/Utils.cpp
@@ -67,6 +67,12 @@ SimpleUrlParse::SimpleUrlParse(const std::string& url) {
         schemeLen = 0;
     }
 
+    // return the full URL if using Unix domain socket
+    if (m_scheme == "unix") {
+        m_netLocation = url;
+        return;
+    }
+
     auto startOfSchemePart = url.find(SCHEME_PART_START, schemeLen);
     if (startOfSchemePart != std::string::npos) {
         startOfSchemePart += SCHEME_PART_START.length();

diff --git a/sdk/tests/unit/Utils_tests.cpp b/sdk/tests/unit/Utils_tests.cpp
@@ -121,3 +121,8 @@ TEST(SimpleUrlParse, ctor_someScheme_slashes_ipAddress_noPort_pathAndQuery) {
     EXPECT_EQ("somescheme", cut.getScheme());
     EXPECT_EQ("1.2.3.4", cut.getNetLocation());
 }
+TEST(SimpleUrlParse, ctor_unix_domain_socket) {
+    SimpleUrlParse cut("unix:///some/path/to/socket");
+    EXPECT_EQ("unix", cut.getScheme());
+    EXPECT_EQ("unix:///some/path/to/socket", cut.getNetLocation());
+}