Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update license headers and update pre-commit config #75

Merged
merged 9 commits into from
Jan 11, 2024
Merged

Update license headers and update pre-commit config #75

merged 9 commits into from
Jan 11, 2024

Conversation

kse3hi
Copy link
Contributor

@kse3hi kse3hi commented Nov 27, 2023 •
edited
Loading

Describe your changes

Issue ticket number and link

ADO#17300

Checklist - Manual tasks

  • Examples are executing successfully
  • Created/updated unit tests. Code Coverage percentage on new code shall be >= 80%.
  • Created/updated integration tests.
  • Devcontainer can be opened successfully
  • Devcontainer can be opened successfully behind a corporate proxy
  • Devcontainer can be re-built successfully
  • Extended the documentation (e.g. README.md, CONTRIBUTING.md, Velocitas)

BjoernAtBosch
BjoernAtBosch reviewed Nov 28, 2023
View reviewed changes
Copy link
Member

@BjoernAtBosch BjoernAtBosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fixing of .gitignore and corresponding pre-commit stuff required

.dockerignore Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@dennismeister93
Update license header to 2024
77d8de3 
Signed-off-by: Dennis Meister <[email protected]>
MP91
MP91 requested changes Jan 11, 2024
View reviewed changes
.pre-commit-config.yaml Show resolved Hide resolved
NOTICE.md Outdated Show resolved Hide resolved
examples/vehicle_model/service/seats.grpc.pb.h Show resolved Hide resolved
@dennismeister93
PR review findings
481482e 
Signed-off-by: Dennis Meister <[email protected]>
MP91
MP91 approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@MP91 MP91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dennismeister93 dennismeister93 merged commit 3bdf47c into main Jan 11, 2024
5 checks passed
@dennismeister93 dennismeister93 deleted the fix/license_headers branch January 11, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BjoernAtBosch BjoernAtBosch BjoernAtBosch left review comments

@MP91 MP91 MP91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kse3hi @MP91 @BjoernAtBosch @dennismeister93