Use correct targetplatform

[erikbosch]

Based on mail on velocitas-dev (see below)

Similar setup already used in
https://github.com/eclipse-velocitas/vehicle-app-python-template/blob/main/app/Dockerfile

When testing with --platform=linux/arm64 I did not notice any problems using scratch in the last step, and for scratch platform should not matter right, it just copies what we have from previous step, or?

FROM --platform=$TARGETPLATFORM gcr.io/distroless/base-debian12 as runner

Tests performed

Built locally with platform flag on a Debian VM for arm64

sudo apt-get install qemu binfmt-support qemu-user-static
docker run --rm --privileged multiarch/qemu-user-static --reset -p yes
docker build -f app/Dockerfile --progress=plain --platform=linux/arm64 -t ex3:latest .
docker image inspect ex3:latest | grep Arch

• Setup has been tested on https://github.com/erikbosch/vehicle-example-app3

Original mail

Hi Velocitas-dev Team,

_We found a maybe a minor issue in the Dockerfile when building it for arm64 machines.

Background:
We are creating a POC using the vehicle-app-cpp-template.
Everything worked great when we built the docker images in our host machine (amd64) and deployed it in ubuntu test machine (amd64).
However, when we built the docker image for arm64 and still using our host machine (amd64) and to be deployed in our edge devices (arm64).
The final image is still in amd64.

This is how docker build the apps:
$ cd vehicle-app-cpp-template/app
$ docker build -f app/Dockerfile --progress=plain --build-arg TARGETPLATFORM=linux/arm64 -t localhost:12345/app-seat-adjuster:0.0.1 .

After building it we docker image inspect the docker image.: 
$ docker image inspect localhost:12345/app-seat-adjuster:0.0.1 | grep Arch
$ "Architecture": "amd64",

We fixed it by modifying cd vehicle-app-cpp-template/app/Dockerfile.
# FROM ghcr.io/eclipse-velocitas/devcontainer-base-images/cpp:v0.3 as builder
FROM --platform=$TARGETPLATFORM ghcr.io/eclipse-velocitas/devcontainer-base-images/cpp:v0.3 as builder
and
# FROM --platform=$TARGETPLATFORM scratch as runner
FROM --platform=$TARGETPLATFORM gcr.io/distroless/base-debian12 as runner

Note:
•	We did not use scratch since it will still default to linux/amd64 even supplying --platform=linux/arm64

After this minor fix. We can now successfully deploy it with our edge devices (arm64).

Does our Dockerfile changes is correct way to go forward or do you recommend another way to build docker(arm64) images using host(amd64)?

Your response is highly appreciated.

Thank you,_ 

[erikbosch]

This is needed to make CI happy, fails also on main currently, same for license checks

[dennismeister93]

Yes with the new version of the cli (Which is part of the new base image) this dockerfile is maintained through our devcontainer-setup. We forgot to update the versions inside velocitas.json (Just for information, the approach is -> Starting the template in devcontainer and execute: velocitas upgrade --ignore-bounds && velocitas init && velocitas sync). Shall i create a seperate PR which is doing it instead of putting this inside this PR?

[erikbosch]

Doesn't really matter for me, if you want to fix it in a separate PR I can later rebase on that PR.

[dennismeister93]

created a PR
#106

[erikbosch]

I managed to get things running for arm without changing "scratch" or adding "--platform" there. It anyway only copy things right, so this should maybe be sufficient.

[MP91]

do you have an arm device? otherwise I would assume doing it like this still requires qemu.

so what I would suggest is to properly use cross compilation (-x )

[erikbosch]

Please have a look on if this seems reasonable. There are a lot of items in the checklist which I do not really know when they are useful. Like when do we actually want to check that "Vehicle App can be deployed to local Kanto runtime and is running". No checks removed so far

[erikbosch]

Fixes #105

[erikbosch]

Converted to draft, PR might not be needed

[erikbosch]

Closing this one, with right arguments no change seems to be needed, see #107