Fix errors in examples #141
Conversation
erikbosch
force-pushed
the
erik_doc
branch
2 times, most recently
from
9e00e19
to
abdb09a
Compare
There was a problem hiding this comment.
IMO if we now do some fixes on the examples we should align everything, that means we should use VSS 4.0 everywhere and also adapt the datapoints accordingly.
Furthermore we should align the structure to have a main and vapp file as in the seat-adjuster example.
If we don't do it correct IMO this PR is not helping a lot, since we still need additional work...
examples/dog-mode/AppManifest.json
Outdated
| "type": "grpc-interface", | ||
| "config": { | ||
| "src": "https://github.com/eclipse/kuksa.val.services/blob/v0.2.0/hvac_service/proto/sdv/edge/comfort/hvac/v1/hvac.proto", | ||
| "src": "https://raw.githubusercontent.com/eclipse/kuksa.val.services/v0.2.0/hvac_service/proto/sdv/edge/comfort/hvac/v1/hvac.proto", | ||
| "required": { | ||
| "methods": [ | ||
| "SetAcStatus", |
There was a problem hiding this comment.
should we remove that completely, since we have the service already defined in the custom model?
There was a problem hiding this comment.
Seems to make sense - we could actually also remove the VSS reference, it isn't used
How is it as of today? Is Databroker always started with default VSS catalog when starting runtime, i.e. not considering what is written in appManifest? If so it makes sense to adapt examples so they all use default VSS version. I did this work mostly to validate that there are no regressions coming from #139 which does not seem to be the case, if we are to verify/update all aspects of each example more time would be needed. It also appears to me that many examples are quite similar, so do we need them all? If we would pend more time on them it would also be great if they could be tested as part of CI when updating SDK. That does not happen today, right? |
According to databroker: velocitas init should download the specified file and add the config for the databroker. so databroker should always be started with the vss file which is defined in the app manifest. Agreed that reworking the examples can take a lot of time, that's why it did not happen so far :D Is there maybe an easy solution to at least be able to use the examples in the template without errors? your initial message at least mentions some more errors besides the ones fixed? |
|
Putting this one on hold for now - before merging we should better run through the examples thoroughly and update documentation. Possibly adapt examples so they can be imported by the template. |
|
I think, it would be already a significant improvement, if we could get rid of using the outdated vehicle-model-python repository with adapting the examples |
Also removing links to the obsolete vehicle-model-python repository Fixes things that seems to be obviously wrong, resulting in that "velocitas init" fail or that Removing dead config
I performed the following test:
What I fixed:
velocitas init(except VSS version missmatch)sdv_modelnot found)What I did not fix: