Code cleanup #1006
Merged
Code cleanup #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import org.eclipse.lsp4e.LSPEclipseUtils; | ||
| import org.eclipse.lsp4j.Location; | ||
| import org.eclipse.search.ui.text.Match; | ||
|
|
||
| public class URIMatch extends Match { | ||
|
|
||
| public final @NonNull Location location; | ||
| public static URIMatch create(final Location location) throws BadLocationException, URISyntaxException { |
There was a problem hiding this comment.
What's wrong with sticking to a constructor here?
There was a problem hiding this comment.
The problem is that the first invocation in a constructor needs to be a super() call, that's why the current implementation parses the URI three times instead of once and then reusing the uri object to construct arguments for the parent constructor. which is very inefficient.
That is what we have currently:
public URIMatch(@NonNull Location location) throws BadLocationException {
super(
URI.create(location.getUri()),
LSPEclipseUtils.toOffset(location.getRange().getStart(), LSPEclipseUtils.getDocument(URI.create(location.getUri()))),
LSPEclipseUtils.toOffset(location.getRange().getEnd(), LSPEclipseUtils.getDocument(URI.create(location.getUri()))) - LSPEclipseUtils.toOffset(location.getRange().getStart(), LSPEclipseUtils.getDocument(URI.create(location.getUri()))));
this.location = location;
}There was a problem hiding this comment.
OK, thanks. Can't wait for https://openjdk.org/jeps/447 ;)
There was a problem hiding this comment.
OK, thanks. Can't wait for openjdk.org/jeps/447 ;)
Me too!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.