Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact: cleanup SupportedFeatures class #1076

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Conversation

sebthom
Copy link
Member

@sebthom sebthom commented Aug 23, 2024

This PR cleans up the SupportedFeatures class:

  1. Format code for better readability
  2. use primitive true instead of verbose Boolean.TRUE
  3. use SymbolKind.values() instead of naming each symbol kind separately

@sebthom
Copy link
Member Author

sebthom commented Aug 23, 2024

@rubenporras I saw that we are currently not announcing the capability CodeAction.SourceFixAll. Is that omitted on purpose?

@rubenporras
Copy link
Contributor

@rubenporras I saw that we are currently not announcing the capability CodeAction.SourceFixAll. Is that omitted on purpose?

Not that I am aware of, but I came to LSP4E when most of the code was already in place. Maybe @mickaelistria knows?

@sebthom sebthom merged commit 69b08ed into eclipse:main Aug 23, 2024
6 checks passed
@sebthom sebthom deleted the refactor branch August 23, 2024 11:45
@mickaelistria
Copy link
Contributor

I saw that we are currently not announcing the capability CodeAction.SourceFixAll. Is that omitted on purpose?

CodeAction.SourceFixAll was introduced relatively recently. We forgot to declare it when it was added to the LSP spec and LSP4J, and since it has caused no issue so far, it remained forgotten.

@sebthom
Copy link
Member Author

sebthom commented Aug 26, 2024

@mickaelistria is it as simple as adding it to the list of supported features or do we need to do anything else?

@mickaelistria
Copy link
Contributor

I don't know for this particular case. Some new LSP features require some development in LSP4E, some do not and can just be declared as supported...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants