Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2x): API Change in V2xMessage getPayLoad -> getPayload #375

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

schwepmo
Copy link
Contributor

@schwepmo schwepmo commented Jan 24, 2024

Description

  • This PR introduces an API change to correct spelling
  • the method V2xMessage#getPayLoad is now correctly spelled as V2xMessage#getPayload
  • all occurrences using this API were adjusted accordingly

BREAKING CHANGE: Applications using the V2xMessage#getPayLoad()-method will have to adjust to the corrected spelling of V2xMessage#getPayload()

Issue(s) related to this PR

  • Resolves internal issue 771

Affected parts of the online documentation

  • None, if I checked properly

Definition of Done

Prerequisites

  • You have read CONTRIBUTING.md carefully.
  • You have signed the Contributor License Agreement.
  • Your GitHub user id is linked with your Eclipse Account.

Required

  • The title of this merge request follows the scheme type(scope): description (in the style of Conventional Commits)
  • You have assigned a suitable label to this pull request (e.g., enhancement, or bugfix)
  • origin/main has been merged into your Fork.
  • Coding guidelines have been followed (see CONTRIBUTING.md).
  • All checks on GitHub pass.
  • All tests on Jenkins pass.

Requested (can be enforced by maintainers)

  • New functionality is covered by unit tests or integration tests. Code coverage must not decrease.
  • If a bug has been fixed, a new unit test has been written (beforehand) to prove misbehavior
  • There are no new SpotBugs warnings.

Special notes to reviewer

* all occurrences using this API were adjusted accordingly

BREAKING CHANGE: Applications using the `V2xMessage#getPayLoad()`-method will have to adjust to the corrected spelling of `V2xMessage#getPayload()`

Signed-off-by: Moritz Schweppenhäuser <[email protected]>
@kschrab
Copy link
Contributor

kschrab commented Jan 24, 2024

Have you looked into the bundled scenarios if any of them refers to getPayLoad in the output_config.xml?

@kschrab kschrab merged commit 4f262b5 into main Jan 24, 2024
7 checks passed
@kschrab kschrab deleted the 771-get-payload-api-renaming branch January 24, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean-up Aesthetically improving code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants