Let systemd create directories #3122
Open
+6
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manually creating directories conflicts with systemd service hardening features. Particularly, `ProtectSystem=strict` mounts the filesystem as read-only for the processes started by the unit which leads to `mkdir` failing. By setting `User=mosquitto` and adding `RuntimeDirectory` and `LogsDirectory`, systemd creates `/run/mosquitto` and `/var/log/mosquitto` with the right permissions even `ProtectSystem=strict` is used. Signed-off-by: Guillaume Champagne <[email protected]>
gchamp20
force-pushed
the
enhance-systemd-service-example
branch
from
5fe6d40
to
cb4d276
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Manually creating directories conflicts with systemd service hardening features. Particularly,
ProtectSystem=strictmounts the filesystem has read-only for the processes started by the unit which leads tomkdirfailing.By setting
User=mosquittoand addingRuntimeDirectoryandLogsDirectory, systemd creates/run/mosquittoand/var/log/mosquittowith the right permissions evenProtectSystem=strictis used.Adding
User=mosquittoalso has the side effect of running the daemon as the usermosquitto. IChecklist
Have you signed the Eclipse Contributor Agreement, using the same email address as you used in your commits?
https://accounts.eclipse.org/users/gchamp20, submitted, appears to be pending? I can still re-submit but I now get an error.
Do each of your commits have a "Signed-off-by" line, with the correct email address? Use "git commit -s" to generate this line for you.
If you are contributing a new feature, is your work based off the develop branch?
If you are contributing a bugfix, is your work based off the fixes branch?
Have you added an explanation of what your changes do and why you'd like us to include them?
Have you successfully run
make testwith your changes locally?