Fix builtin __gdsa function call for Open XL #7419
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building Open J9, Open XL throws an error building CallStack.cpp as extern builtins unsupported. This adds the appropriate alternative that works with Open XL and allows compilation. Signed-off-by: Gaurav Chaudhari <[email protected]>
|
jenkins build zos |
babsingh
reviewed
Sep 17, 2024
There was a problem hiding this comment.
there is only one instance of ifdefs being commented at the end of this file. the suggested formatting in the coding standard should be followed: https://github.com/eclipse/omr/blob/3223d8d0d584575eafb5ec462250baae92cd6084/doc/CodingStandard.md#comment-conditional-compilation-directives-if-ifdef-ifndef-else-elif-endif
| extern "builtin" void *__gdsa(); | ||
| #endif // !defined(__open_xl__) |
There was a problem hiding this comment.
Suggested change
| #endif // !defined(__open_xl__) | |
| #endif /* !defined(__open_xl__) */ |
|
|
||
| TR_MvsCallStackIterator::TR_MvsCallStackIterator () | ||
| : TR_CallStackIterator() | ||
| { | ||
| #if defined(__open_xl__) | ||
| _parms.__tf_dsa_addr = (void*)__builtin_s390_gdsa(); | ||
| #else |
There was a problem hiding this comment.
Suggested change
| #else | |
| #else /* !defined(__open_xl__) */ |
| _parms.__tf_dsa_addr = (void*)__gdsa(); | ||
| #endif // defined(__open_xl__) |
There was a problem hiding this comment.
Suggested change
| #endif // defined(__open_xl__) | |
| #endif /* !defined(__open_xl__) */ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building Open J9, Open XL throws an error building CallStack.cpp as extern builtins unsupported. This adds the appropriate alternative that works with Open XL and allows compilation.