Add omrthread_get_self_thread_time() #7491
Open
+58
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thallium
added a commit
to thallium/openj9
that referenced
this pull request
Oct 10, 2024
Depends on: eclipse/omr#7491 Signed-off-by: Gengchen Tuo <[email protected]>
tajila
reviewed
Oct 10, 2024
| @@ -0,0 +1,41 @@ | |||
| #if defined (LINUX) | |||
There was a problem hiding this comment.
if this is specific to linux, it needs to be in the linux dir not common
There was a problem hiding this comment.
youll still have to add a common implementation, even if all it does is return an error
There was a problem hiding this comment.
I'm trying to make it work for all the platforms
|
@babsingh Please review |
|
Minor nit: please fix the spelling of "thread" in your commit and PR titles. Thanks. |
This function returns the user and system cpu time of the calling thread. Related: eclipse-openj9/openj9#20186 Signed-off-by: Gengchen Tuo <[email protected]>
thallium
changed the title
|
Fixed spelling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function returns the user and system cpu time of the calling thread.
Related: eclipse-openj9/openj9#20186