Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conditionally required property not applying #2228

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
9746c81
Add new example for conditional required
gatanasov-asteasolutions Dec 5, 2023
67ab199
Fix required not showing with conditional subschemas
gatanasov-asteasolutions Dec 5, 2023
9afddab
Add pattern support and nested checks
gatanasov-asteasolutions Dec 6, 2023
2cf5824
Add support for nested allOf and if-then-else
gatanasov-asteasolutions Dec 6, 2023
4455ed2
Address comments about nested structures
gatanasov-asteasolutions Dec 11, 2023
ea425a6
Fix wrong calling of condition
gatanasov-asteasolutions Dec 11, 2023
1e18a5e
Add check for required in parent schema
gatanasov-asteasolutions Dec 12, 2023
2fcb0f7
Merge pull request #1 from gatanasov-asteasolutions/fix_conditional_r…
gatanasov-asteasolutions Dec 13, 2023
9119c78
Merge branch 'eclipsesource:master' into master
gatanasov-asteasolutions Dec 13, 2023
3e466c8
Merge branch 'eclipsesource:master' into master
gatanasov-asteasolutions Jan 8, 2024
d11e2b6
Add tests for conditionally required logic
gatanasov-asteasolutions Jan 9, 2024
0d3f614
Add more tests and make conditionally required check optional
gatanasov-asteasolutions Jan 10, 2024
ec4273a
Merge pull request #2 from gatanasov-asteasolutions/add-tests-for-con…
gatanasov-asteasolutions Jan 10, 2024
a94ef35
Modify conditionallyRequired logic to handle arrays
KManolov3 Feb 15, 2024
0cc6dda
Remove redundant comments
KManolov3 Feb 15, 2024
ad4614a
Add additional check to prevent accessing undefined data
KManolov3 Feb 19, 2024
a6f0d7b
Remove comments from renderer.ts
gatanasov-asteasolutions Aug 27, 2024
2b9dad3
Merge branch 'master' of https://github.com/eclipsesource/jsonforms i…
gatanasov-asteasolutions Aug 27, 2024
f963f79
Merge branch 'master' into backmerge-jsonforms-base
gatanasov-asteasolutions Aug 27, 2024
c3d333f
Merge pull request #5 from gatanasov-asteasolutions/backmerge-jsonfor…
gatanasov-asteasolutions Aug 27, 2024
e53b121
Merge branch 'master' into additional-checks-for-array-handling
gatanasov-asteasolutions Aug 27, 2024
f1f81dc
Merge pull request #3 from gatanasov-asteasolutions/additional-checks…
gatanasov-asteasolutions Aug 28, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions packages/core/src/configDefault.ts
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
/*
The MIT License

Copyright (c) 2017-2019 EclipseSource Munich
https://github.com/eclipsesource/jsonforms

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
Expand Down Expand Up @@ -45,4 +45,10 @@ export const configDefault = {
* [text] if asterisks in labels for required fields should be hidden
*/
hideRequiredAsterisk: false,

/**
* [text] if dynamic checks for conditional application of properties
* should be performed (e.g. check for conditional required)
*/
allowDynamicCheck: false,
};
Loading
Loading