Vanilla TextCell password #2249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For vanilla-renderers TextCell, use "type" option to select an alternative HTML5 input type such as "email" or "password"
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
sdirix
requested changes
Jan 11, 2024
Sounds great, changed to |
sdirix
requested changes
Jan 22, 2024
Comment on lines
+53
to
+55
| type={ | ||
| appliedUiSchemaOptions.format ? appliedUiSchemaOptions.format : 'text' | ||
| } |
There was a problem hiding this comment.
Suggested change
| type={ | |
| appliedUiSchemaOptions.format ? appliedUiSchemaOptions.format : 'text' | |
| } | |
| type={appliedUiSchemaOptions.format === 'password' ? 'password' : 'text'} |
There was a problem hiding this comment.
I would prefer only passing through the password as in React Material. Other types might be incompatible. I would have applied the change myself but maintainer editing was turned off for this PR
|
Closed in favor of #2254. Thanks for the contribution ❤️ |
|
Thanks @sdirix ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The input type for a TextCell in the vanilla-renderers was 'text' and could not be changed.
This change keeps the default 'text' type but allows the type to be changed via an option "type"
"options": { "format": "password" }See also:
https://jsonforms.discourse.group/t/input-type-with-vanilla-renderers/272