add dynamic enum Tutorial #278
Open
+548
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasBoll
force-pushed
the
dynamicEnumTutorial
branch
from
7a344e3 to
7654703
Compare
sdirix
reviewed
Feb 19, 2024
LukasBoll
force-pushed
the
dynamicEnumTutorial
branch
from
3af8f33 to
99d4152
Compare
sdirix
requested changes
Mar 20, 2024
| /> | ||
| ); | ||
| }; | ||
| ``` |
There was a problem hiding this comment.
Please add the wrapping code for the renderers, i.e. withJsonFormsControlProps etc. here and in the other listings.
LukasBoll
force-pushed
the
dynamicEnumTutorial
branch
from
d2d24bc to
d6205ec
Compare
Co-authored-by: Stefan Dirix <[email protected]> closes eclipsesource#270
LukasBoll
force-pushed
the
dynamicEnumTutorial
branch
from
817dd55 to
23fa126
Compare
|
thank you, I applied the changes from your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #270