docs: fix broken link in what-is-jsonforms page #305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sdirix
requested changes
Dec 10, 2024
There was a problem hiding this comment.
Hi @AssekoudaSamtou, thanks for the contribution ❤️
However the issue is not in the link itself. The issue comes from the top nav bar not appending the trailing slash, e.g. when you append the trailing slash yourself in the Browser or click on "What is JSON Forms?" then the link works.
I think we need to adjust these to entries here to specify a trailing slash
sdirix
added a commit
to sdirix/jsonforms2-website
that referenced
this pull request
Jan 13, 2025
Fixes an issue in which nested links where not applied to the current route as it did not end in slash. This lead to invalid links and 404 errors when following such links. See eclipsesource#305 for more information.
sdirix
added a commit
to sdirix/jsonforms2-website
that referenced
this pull request
Jan 13, 2025
Fixes an issue in which nested links where not applied to the current route as it did not end in slash. This lead to invalid links and 404 errors when following such links. See eclipsesource#305 for more information.
sdirix
added a commit
to sdirix/jsonforms2-website
that referenced
this pull request
Jan 13, 2025
Fixes an issue in which nested links were not applied to the current route as it did not end in slash. This lead to invalid links and 404 errors when following such links. See eclipsesource#305 for more information.
sdirix
added a commit
to sdirix/jsonforms2-website
that referenced
this pull request
Jan 13, 2025
Fixes an issue in which nested links were not applied to the current route as it did not end in slash. This lead to invalid links and 404 errors when following such links. See eclipsesource#305 for more information.
sdirix
added a commit
that referenced
this pull request
Jan 13, 2025
Fixes an issue in which nested links were not applied to the current route as it did not end in slash. This lead to invalid links and 404 errors when following such links. See #305 for more information.
|
Fixed with eebccfa |
|
Hello @sdirix, thank you for looking into the issue and giving me more details. Happy you fixed it 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you hover and click the
Getting startedlink at the end of the documentation homepage (Figure 1), it takes you to 404-pagehttps://jsonforms.io/getting-started(Figure 2).Figure 1
Figure 2