Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 3.5.1 and various fixes #307

Merged
merged 4 commits into from
Jan 13, 2025

Conversation

sdirix
Copy link
Member

@sdirix sdirix commented Jan 13, 2025

No description provided.

@sdirix sdirix marked this pull request as ready for review January 13, 2025 10:44
@sdirix sdirix requested a review from lucas-koehler January 13, 2025 10:44
@lucas-koehler lucas-koehler changed the title Update to 3.5.0 Update to 3.5.1 and various fixes Jan 13, 2025
Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sdirix , thanks for the updates! This already looks pretty good to me and I can confirm that the CSP changes fix the API docs for me 🥳

I only have one concern about probably accidentally committed changes to current-versions.js

static/current-version.js Outdated Show resolved Hide resolved
- Update to JSON Forms 3.5.1
- Update API docs
- Add release news for 3.5.0

Also updates to latest Docusaurus which fixes search
The generated API docs contain inline scripts, inline styles and data
sources. This adapts the Netlify configuration to serve a more relaxed
CSP for them.
Fixes an issue in which nested links were not applied to the current
route as it did not end in slash. This lead to invalid links and 404
errors when following such links.

See eclipsesource#305 for more information.
The GH action we use to daily check our website for issues did no
longer work as its implementation is incompatible to the latest
Ubuntu (24.04) default settings. Pins the Ubuntu version to 22.04 to fix
the issue for now.
Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks ✨

@sdirix sdirix merged commit 81bf453 into eclipsesource:master Jan 13, 2025
2 checks passed
@sdirix sdirix deleted the update-to-3.5.0 branch January 13, 2025 11:28
@sdirix sdirix mentioned this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants