Skip to content

Commit

Permalink
Remove workaround comment from animate-tray.jsx
Browse files Browse the repository at this point in the history
Snippets are not the place to document issues. This is a legitimate
optimization even without the bug and should not be removed without
reason, and even if it was it should be tested.

Change-Id: Id75f08e3ffe797b083cd34afd97dea1206583349
  • Loading branch information
tbuschto committed Mar 19, 2020
1 parent c2a3446 commit 4860c69
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion snippets/animate-tray.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ async function positionTrayInRestingState(velocity) {
trayState = 'animating';
const translationY = velocity > 0 ? trayHeight : 0;
const options = {duration: Math.min(Math.abs(trayHeight / velocity * 1000), 800)};
if (tray.transform.translationY !== translationY) { // workaround eclipsesource/tabris-js#1988
if (tray.transform.translationY !== translationY) {
await Promise.all([
shade.animate({opacity: getShadeOpacity(translationY)}, options),
strapIcon.animate({transform: getStrapIconTransform(translationY)}, options),
Expand Down

0 comments on commit 4860c69

Please sign in to comment.