ECLand: Initial CI test pipeline for GNU, Intel and MacOS in double-precision #1
+733
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awnawab
requested changes
Feb 7, 2025
.github/workflows/build.yml
Outdated
| include: | ||
|
|
||
| - name: linux gnu-10 | ||
| os: ubuntu-20.04 |
There was a problem hiding this comment.
We probably want to bump this up to ubuntu-22.04; 20.04 will be deprecated soon.
.github/workflows/build.yml
Outdated
| compiler_cc: gcc-10 | ||
| compiler_cxx: g++-10 | ||
| compiler_fc: gfortran-10 | ||
| ctest_options: -V -E memory |
There was a problem hiding this comment.
Do we need these? I couldn't find a test called "memory", so not sure if we need this exclude here.
.github/workflows/build.yml
Outdated
| # caching: true | ||
|
|
||
| - name : linux intel-classic | ||
| os: ubuntu-20.04 |
There was a problem hiding this comment.
Same comment as above about ubuntu version.
.github/workflows/build.yml
Outdated
| sudo apt-get install libnetcdff-dev | ||
| fi | ||
|
|
||
| pip3 install numpy |
mlange05
force-pushed
the
naml-ci-tests
branch
from
a622650 to
13e8126
Compare
reuterbal
requested changes
Feb 12, 2025
Comment on lines
+84
to
+87
| - name: Set up Python ${{ matrix.python-version }} | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: ${{ matrix.python-version }} |
There was a problem hiding this comment.
Does this use any Python?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An initial test setup that runs CI in double-precision for some of the standard compilers. The install scripts are taken from ecRad and ecWAM, largely and simply execute the to standard tests via ctest.
Currently supported (and not yet supported):
Please note that single precision failed to compile with several toolchains due to a utility routine (MINMAX) being called from precision-variant and precision-invariant code paths (with JPRB and JPRD). I've left the hooks in the workflow file for fixing in a separate PR.