-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python binding ectrans4py
#205
base: develop
Are you sure you want to change the base?
Python binding ectrans4py
#205
Conversation
@samhatfield I guess I'd need to re-rebase this (commits 8f57c77 to b900eed) on top of #203 or even |
Yes exactly! :) Then you can just force push to your repo and the PR will update itself. |
OK I wait for 203 to be merged in develop then. |
Hi @AlexandreMary - you can try rebasing this branch against develop now. |
(cherry picked from commit 8d9307f)
b900eed
to
3c0c564
Compare
Rebasing done, branch force-pushed. |
ectrans4py
ectrans4py
ectrans4py
ectrans4py
License of |
@@ -0,0 +1,20 @@ | |||
if(HAVE_ETRANS) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because HAVE_ETRANS
is a condition of the ECTRANS4PY
feature, I think this if statement is not necessary.
|
||
ecbuild_add_option( FEATURE ECTRANS4PY | ||
DEFAULT OFF | ||
CONDITION HAVE_ETRANS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand right, HAVE_DOUBLE_PRECISION
is effectively a condition for ECTRANS4PY
. Why not make it "official" and put it as a condition here?
This branch, based on PRs #203 and #204, introduces the Python binding
ectrans4py
.This is a Python interface to some
ectrans
functions, mainly the necessary routines to be able to:both for global and LAM fields.
It uses
ctypesForFortran
Python package for the Fortran<>Python interface.Note: version number is duplicated in
src/ectrans4py/__init__.py
for now, until better solution.Replaces PR #199